-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make coordinates of vector data chunks independent from scene origin #59174
Merged
nyalldawson
merged 13 commits into
qgis:master
from
wonder-sk:vectors-3d-relative-to-chunk-origin
Oct 25, 2024
Merged
Make coordinates of vector data chunks independent from scene origin #59174
nyalldawson
merged 13 commits into
qgis:master
from
wonder-sk:vectors-3d-relative-to-chunk-origin
Oct 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wonder-sk
added
Frozen
Feature freeze - Do not merge!
3D
Relates to QGIS' 3D engine or rendering
labels
Oct 22, 2024
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
This is a continuation of work started in qgis#58948, handling all the cases of data from vector layers.
wonder-sk
force-pushed
the
vectors-3d-relative-to-chunk-origin
branch
from
October 23, 2024 08:29
2b7c460
to
2c65c3a
Compare
The texture was barely visible at all, so let's magnify it
We just flip axes at the transform where needed back to world coordinates. Make instanced renderer shader respect any QTransform and clean up its code
Flipping back to world coordinates is done in QTransform
wonder-sk
force-pushed
the
vectors-3d-relative-to-chunk-origin
branch
from
October 23, 2024 20:45
7e2ac2f
to
4f75f77
Compare
This should be ready for review... |
nyalldawson
approved these changes
Oct 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Co-authored-by: Nyall Dawson <[email protected]>
wonder-sk
commented
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of work started in #58948, handling all the cases of data from vector layers. No change of functionality, just changing what coordinates are stored in geometries sent to GPU.
Also: